Public/kotaemon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: using a base path breaks file preview (#575)

Browse Source 
* fix: using a base path breaks file preview

* fix: comfort precommit

---------

Co-authored-by: Varun Sharma <contactvarun27@gmail.com>
This commit is contained in:
Tuan Anh Nguyen Dang (Tadashi_Cin) 2024-12-17 17:12:27 +07:00 committed by GitHub
parent a8b8fcea32
commit 9039b4f32b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libs/ktem/ktem/app.py
View File

@ -1,3 +1,4 @@
import os
from pathlib import Path from pathlib import Path
from typing import Optional from typing import Optional
@ -12,6 +13,8 @@ from ktem.settings import BaseSettingGroup, SettingGroup, SettingReasoningGroup
from theflow.settings import settings from theflow.settings import settings
from theflow.utils.modules import import_dotted_string from theflow.utils.modules import import_dotted_string
BASE_PATH = os.environ.get("GRADIO_ROOT_PATH", "")
class BaseApp: class BaseApp:
"""The main app of Kotaemon """The main app of Kotaemon
@ -54,7 +57,7 @@ class BaseApp:
self._pdf_view_js = self._pdf_view_js.replace( self._pdf_view_js = self._pdf_view_js.replace(
"PDFJS_PREBUILT_DIR", "PDFJS_PREBUILT_DIR",
pdf_js_dist_dir, pdf_js_dist_dir,
) ).replace("GRADIO_ROOT_PATH", BASE_PATH)
with (dir_assets / "js" / "svg-pan-zoom.min.js").open() as fi: with (dir_assets / "js" / "svg-pan-zoom.min.js").open() as fi:
self._svg_js = fi.read() self._svg_js = fi.read()

2
libs/ktem/ktem/assets/js/pdf_viewer.js
View File

@ -17,7 +17,7 @@ function onBlockLoad () {
<span class="close" id="modal-expand">&#x26F6;</span> <span class="close" id="modal-expand">&#x26F6;</span>
</div> </div>
<div class="modal-body"> <div class="modal-body">
<pdfjs-viewer-element id="pdf-viewer" viewer-path="/file=PDFJS_PREBUILT_DIR" locale="en" phrase="true"> <pdfjs-viewer-element id="pdf-viewer" viewer-path="GRADIO_ROOT_PATH/file=PDFJS_PREBUILT_DIR" locale="en" phrase="true">
</pdfjs-viewer-element> </pdfjs-viewer-element>
</div> </div>
</div> </div>

6
libs/ktem/ktem/utils/render.py
View File

@ -1,10 +1,12 @@
import os.path import os
import markdown import markdown
from fast_langdetect import detect from fast_langdetect import detect
from kotaemon.base import RetrievedDocument from kotaemon.base import RetrievedDocument
BASE_PATH = os.environ.get("GRADIO_ROOT_PATH", "")
def is_close(val1, val2, tolerance=1e-9): def is_close(val1, val2, tolerance=1e-9):
return abs(val1 - val2) <= tolerance return abs(val1 - val2) <= tolerance
@ -104,7 +106,7 @@ class Render:
return f""" return f"""
{html_content} {html_content}
<a href="#" class="pdf-link" data-src="/file={pdf_path}" data-page="{page_idx}" data-search="{highlight_text}" data-phrase="{phrase}"> <a href="#" class="pdf-link" data-src="{BASE_PATH}/file={pdf_path}" data-page="{page_idx}" data-search="{highlight_text}" data-phrase="{phrase}">
[Preview] [Preview]
</a> </a>
""" # noqa """ # noqa