Mirror/FairMQ
1
0
Fork 0
mirror of https://github.com/FairRootGroup/FairMQ.git synced 2025-10-13 08:41:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modernize ctor

Browse Source 
https://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html#pass-by-value-in-constructors
This commit is contained in:
Dennis Klein 2019-12-11 15:21:00 +01:00 committed by Dennis Klein
parent 8e3f25851c
commit fd2bac3e22
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
fairmq/Plugin.cxx
View File

@ -1,5 +1,5 @@
/******************************************************************************** /********************************************************************************
* Copyright (C) 2017 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH * * Copyright (C) 2017-2019 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH *
* * * *
* This software is distributed under the terms of the * * This software is distributed under the terms of the *
* GNU Lesser General Public Licence (LGPL) version 3, * * GNU Lesser General Public Licence (LGPL) version 3, *
@ -8,15 +8,20 @@
#include <fairmq/Plugin.h> #include <fairmq/Plugin.h>
#include <FairMQLogger.h> #include <FairMQLogger.h>
#include <utility>
using namespace std; using namespace std;
fair::mq::Plugin::Plugin(const string name, const Version version, const string maintainer, const string homepage, PluginServices* pluginServices) fair::mq::Plugin::Plugin(string name,
: fkName{name} Version version,
string maintainer,
string homepage,
PluginServices* pluginServices)
: fkName(std::move(name))
, fkVersion(version) , fkVersion(version)
, fkMaintainer{maintainer} , fkMaintainer(std::move(maintainer))
, fkHomepage{homepage} , fkHomepage(std::move(homepage))
, fPluginServices{pluginServices} , fPluginServices(pluginServices)
{ {
LOG(debug) << "Loaded plugin: " << *this; LOG(debug) << "Loaded plugin: " << *this;
} }

8
fairmq/Plugin.h
View File

@ -1,5 +1,5 @@
/******************************************************************************** /********************************************************************************
* Copyright (C) 2017 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH * * Copyright (C) 2017-2019 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH *
* * * *
* This software is distributed under the terms of the * * This software is distributed under the terms of the *
* GNU Lesser General Public Licence (LGPL) version 3, * * GNU Lesser General Public Licence (LGPL) version 3, *
@ -44,7 +44,11 @@ class Plugin
using Version = tools::Version; using Version = tools::Version;
Plugin() = delete; Plugin() = delete;
Plugin(const std::string name, const Version version, const std::string maintainer, const std::string homepage, PluginServices* pluginServices); Plugin(std::string name,
Version version,
std::string maintainer,
std::string homepage,
PluginServices* pluginServices);
Plugin(const Plugin&) = delete; Plugin(const Plugin&) = delete;
Plugin operator=(const Plugin&) = delete; Plugin operator=(const Plugin&) = delete;