Apply readability-avoid-const-params-in-decls

This commit is contained in:
Alexey Rybalchenko
2021-09-13 10:57:36 +02:00
committed by Dennis Klein
parent 42a7e298c0
commit f33c597f34
27 changed files with 132 additions and 132 deletions

View File

@@ -152,7 +152,7 @@ class Message final : public fair::mq::Message
}
}
void Rebuild(const size_t size) override
void Rebuild(size_t size) override
{
CloseMessage();
fMsg = std::make_unique<zmq_msg_t>();
@@ -161,7 +161,7 @@ class Message final : public fair::mq::Message
}
}
void Rebuild(const size_t size, Alignment alignment) override
void Rebuild(size_t size, Alignment alignment) override
{
CloseMessage();
fAlignment = alignment.alignment;
@@ -179,7 +179,7 @@ class Message final : public fair::mq::Message
}
}
void Rebuild(void* data, const size_t size, fairmq_free_fn* ffn, void* hint = nullptr) override
void Rebuild(void* data, size_t size, fairmq_free_fn* ffn, void* hint = nullptr) override
{
CloseMessage();
fMsg = std::make_unique<zmq_msg_t>();
@@ -204,7 +204,7 @@ class Message final : public fair::mq::Message
// destroyed. Used size is applied only once in ApplyUsedSize, which is called by the socket
// before sending. This function just updates the desired size until the actual "resizing"
// happens.
bool SetUsedSize(const size_t size) override
bool SetUsedSize(size_t size) override
{
if (size == GetSize()) {
// nothing to do

View File

@@ -105,7 +105,7 @@ class Poller final : public fair::mq::Poller
Poller(const Poller&) = delete;
Poller operator=(const Poller&) = delete;
void SetItemEvents(zmq_pollitem_t& item, const int type)
void SetItemEvents(zmq_pollitem_t& item, int type)
{
if (type == ZMQ_REQ || type == ZMQ_REP || type == ZMQ_PAIR || type == ZMQ_DEALER || type == ZMQ_ROUTER) {
item.events = ZMQ_POLLIN | ZMQ_POLLOUT;
@@ -119,7 +119,7 @@ class Poller final : public fair::mq::Poller
}
}
void Poll(const int timeout) override
void Poll(int timeout) override
{
while (true) {
if (zmq_poll(fItems, fNumItems, timeout) < 0) {
@@ -138,7 +138,7 @@ class Poller final : public fair::mq::Poller
}
}
bool CheckInput(const int index) override
bool CheckInput(int index) override
{
if (fItems[index].revents & ZMQ_POLLIN) {
return true;
@@ -147,7 +147,7 @@ class Poller final : public fair::mq::Poller
return false;
}
bool CheckOutput(const int index) override
bool CheckOutput(int index) override
{
if (fItems[index].revents & ZMQ_POLLOUT) {
return true;
@@ -156,7 +156,7 @@ class Poller final : public fair::mq::Poller
return false;
}
bool CheckInput(const std::string& channelKey, const int index) override
bool CheckInput(const std::string& channelKey, int index) override
{
try {
if (fItems[fOffsetMap.at(channelKey) + index].revents & ZMQ_POLLIN) {
@@ -171,7 +171,7 @@ class Poller final : public fair::mq::Poller
}
}
bool CheckOutput(const std::string& channelKey, const int index) override
bool CheckOutput(const std::string& channelKey, int index) override
{
try {
if (fItems[fOffsetMap.at(channelKey) + index].revents & ZMQ_POLLOUT) {

View File

@@ -131,7 +131,7 @@ class Socket final : public fair::mq::Socket
}
}
int64_t Send(MessagePtr& msg, const int timeout = -1) override
int64_t Send(MessagePtr& msg, int timeout = -1) override
{
int flags = 0;
if (timeout == 0) {
@@ -161,7 +161,7 @@ class Socket final : public fair::mq::Socket
}
}
int64_t Receive(MessagePtr& msg, const int timeout = -1) override
int64_t Receive(MessagePtr& msg, int timeout = -1) override
{
int flags = 0;
if (timeout == 0) {
@@ -191,7 +191,7 @@ class Socket final : public fair::mq::Socket
}
}
int64_t Send(std::vector<std::unique_ptr<fair::mq::Message>>& msgVec, const int timeout = -1) override
int64_t Send(std::vector<std::unique_ptr<fair::mq::Message>>& msgVec, int timeout = -1) override
{
int flags = 0;
if (timeout == 0) {
@@ -243,7 +243,7 @@ class Socket final : public fair::mq::Socket
}
}
int64_t Receive(std::vector<std::unique_ptr<fair::mq::Message>>& msgVec, const int timeout = -1) override
int64_t Receive(std::vector<std::unique_ptr<fair::mq::Message>>& msgVec, int timeout = -1) override
{
int flags = 0;
if (timeout == 0) {
@@ -329,7 +329,7 @@ class Socket final : public fair::mq::Socket
return zmq_getsockopt(fSocket, ZMQ_EVENTS, events, &eventsSize);
}
void SetLinger(const int value) override
void SetLinger(int value) override
{
if (zmq_setsockopt(fSocket, ZMQ_LINGER, &value, sizeof(value)) < 0) {
throw SocketError(tools::ToString("failed setting ZMQ_LINGER, reason: ", zmq_strerror(errno)));
@@ -346,7 +346,7 @@ class Socket final : public fair::mq::Socket
return value;
}
void SetSndBufSize(const int value) override
void SetSndBufSize(int value) override
{
if (zmq_setsockopt(fSocket, ZMQ_SNDHWM, &value, sizeof(value)) < 0) {
throw SocketError(tools::ToString("failed setting ZMQ_SNDHWM, reason: ", zmq_strerror(errno)));
@@ -363,7 +363,7 @@ class Socket final : public fair::mq::Socket
return value;
}
void SetRcvBufSize(const int value) override
void SetRcvBufSize(int value) override
{
if (zmq_setsockopt(fSocket, ZMQ_RCVHWM, &value, sizeof(value)) < 0) {
throw SocketError(tools::ToString("failed setting ZMQ_RCVHWM, reason: ", zmq_strerror(errno)));
@@ -380,7 +380,7 @@ class Socket final : public fair::mq::Socket
return value;
}
void SetSndKernelSize(const int value) override
void SetSndKernelSize(int value) override
{
if (zmq_setsockopt(fSocket, ZMQ_SNDBUF, &value, sizeof(value)) < 0) {
throw SocketError(tools::ToString("failed getting ZMQ_SNDBUF, reason: ", zmq_strerror(errno)));
@@ -397,7 +397,7 @@ class Socket final : public fair::mq::Socket
return value;
}
void SetRcvKernelSize(const int value) override
void SetRcvKernelSize(int value) override
{
if (zmq_setsockopt(fSocket, ZMQ_RCVBUF, &value, sizeof(value)) < 0) {
throw SocketError(tools::ToString("failed getting ZMQ_RCVBUF, reason: ", zmq_strerror(errno)));

View File

@@ -56,22 +56,22 @@ class TransportFactory final : public FairMQTransportFactory
return std::make_unique<Message>(alignment, this);
}
MessagePtr CreateMessage(const size_t size) override
MessagePtr CreateMessage(size_t size) override
{
return std::make_unique<Message>(size, this);
}
MessagePtr CreateMessage(const size_t size, Alignment alignment) override
MessagePtr CreateMessage(size_t size, Alignment alignment) override
{
return std::make_unique<Message>(size, alignment, this);
}
MessagePtr CreateMessage(void* data, const size_t size, fairmq_free_fn* ffn, void* hint = nullptr) override
MessagePtr CreateMessage(void* data, size_t size, fairmq_free_fn* ffn, void* hint = nullptr) override
{
return std::make_unique<Message>(data, size, ffn, hint, this);
}
MessagePtr CreateMessage(UnmanagedRegionPtr& region, void* data, const size_t size, void* hint = 0) override
MessagePtr CreateMessage(UnmanagedRegionPtr& region, void* data, size_t size, void* hint = 0) override
{
return std::make_unique<Message>(region, data, size, hint, this);
}
@@ -96,27 +96,27 @@ class TransportFactory final : public FairMQTransportFactory
return std::make_unique<Poller>(channelsMap, channelList);
}
UnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, RegionCallback callback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
UnmanagedRegionPtr CreateUnmanagedRegion(size_t size, RegionCallback callback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
{
return CreateUnmanagedRegion(size, 0, callback, nullptr, path, flags, cfg);
}
UnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, RegionBulkCallback bulkCallback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
UnmanagedRegionPtr CreateUnmanagedRegion(size_t size, RegionBulkCallback bulkCallback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
{
return CreateUnmanagedRegion(size, 0, nullptr, bulkCallback, path, flags, cfg);
}
UnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, const int64_t userFlags, RegionCallback callback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
UnmanagedRegionPtr CreateUnmanagedRegion(size_t size, int64_t userFlags, RegionCallback callback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
{
return CreateUnmanagedRegion(size, userFlags, callback, nullptr, path, flags, cfg);
}
UnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, const int64_t userFlags, RegionBulkCallback bulkCallback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
UnmanagedRegionPtr CreateUnmanagedRegion(size_t size, int64_t userFlags, RegionBulkCallback bulkCallback, const std::string& path = "", int flags = 0, fair::mq::RegionConfig cfg = fair::mq::RegionConfig()) override
{
return CreateUnmanagedRegion(size, userFlags, nullptr, bulkCallback, path, flags, cfg);
}
UnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, const int64_t userFlags, RegionCallback callback, RegionBulkCallback bulkCallback, const std::string&, int /* flags */, fair::mq::RegionConfig cfg)
UnmanagedRegionPtr CreateUnmanagedRegion(size_t size, int64_t userFlags, RegionCallback callback, RegionBulkCallback bulkCallback, const std::string&, int /* flags */, fair::mq::RegionConfig cfg)
{
UnmanagedRegionPtr ptr = std::make_unique<UnmanagedRegion>(*fCtx, size, userFlags, callback, bulkCallback, this, cfg);
auto zPtr = static_cast<UnmanagedRegion*>(ptr.get());