Fix copy constructor & assignment operator warning in FairMQChannel

Fix Weffc++ warnings

  - Add missing copy constructors and assignment operators .
  - Hide the warning from FairMQStateMachine.h where it is produced by boost and/or is intended.
  - Some code cleanup.

fairmq/options/FairProgOptions.cxx

@@ -18,15 +18,19 @@ using namespace std;
 
 /// //////////////////////////////////////////////////////////////////////////////////////////////////////
 /// Constructor
-FairProgOptions::FairProgOptions() : 
+FairProgOptions::FairProgOptions() :
                         fGenericDesc("Generic options description"),
                         fConfigDesc("Configuration options description"),
                         fHiddenDesc("Hidden options description"),
-                        fEnvironmentDesc("Environment Variables"),
+                        fEnvironmentDesc("Environment variables"),
                         fCmdLineOptions("Command line options"),
                         fConfigFileOptions("Configuration file options"),
                         fVisibleOptions("Visible options"),
-                        fVerboseLvl("INFO"), fUseConfigFile(false), fConfigFile()
+                        fVerboseLvl("INFO"),
+                        fUseConfigFile(false),
+                        fConfigFile(),
+                        fVarMap(),
+                        fSeverityMap()
 {
     // define generic options
     fGenericDesc.add_options()
@@ -141,7 +145,7 @@ int FairProgOptions::ParseCmdLine(const int argc, char** argv, const po::options
 
 int FairProgOptions::ParseCmdLine(const int argc, char** argv, const po::options_description& desc, bool allowUnregistered)
 {
-    return ParseCmdLine(argc,argv,desc,fVarMap,allowUnregistered);
+    return ParseCmdLine(argc, argv, desc, fVarMap, allowUnregistered);
 }
 
 int FairProgOptions::ParseCfgFile(ifstream& ifs, const po::options_description& desc, po::variables_map& varmap, bool allowUnregistered)

fairmq/options/FairProgOptions.h

@@ -96,13 +96,13 @@ class FairProgOptions
 
     // convert value to string that corresponds to the key
     std::string GetStringValue(const std::string& key);
-    
-    const po::variables_map& GetVarMap() const {return fVarMap;}
-    
+
+    const po::variables_map& GetVarMap() const { return fVarMap; }
+
     // boost prog options parsers
     int ParseCmdLine(const int argc, char** argv, const po::options_description& desc, po::variables_map& varmap, bool allowUnregistered = false);
     int ParseCmdLine(const int argc, char** argv, const po::options_description& desc, bool allowUnregistered = false);
-    
+
     int ParseCfgFile(const std::string& filename, const po::options_description& desc, po::variables_map& varmap, bool allowUnregistered = false);
     int ParseCfgFile(const std::string& filename, const po::options_description& desc, bool allowUnregistered = false);
     int ParseCfgFile(std::ifstream& ifs, const po::options_description& desc, po::variables_map& varmap, bool allowUnregistered = false);

fairmq/options/FairProgOptionsHelper.h

@@ -25,8 +25,6 @@
 #include <iterator>
 #include <tuple>
 
-
-
 template<class T>
 std::ostream& operator<<(std::ostream& os, const std::vector<T>& v)
 {
@@ -36,9 +34,8 @@ std::ostream& operator<<(std::ostream& os, const std::vector<T>& v)
 
 namespace fairmq
 {
-    
     namespace po = boost::program_options;
-    
+
     //_____________________________________________________________________________________________________________________________
 
     template<typename T>
@@ -108,6 +105,7 @@ namespace fairmq
             return std::string("empty value");
         }
     };
+
 //_____________________________________________________________________________________________________________________________
 
     // policy to convert variable value content into a tuple with value, type, defaulted, empty information