diff --git a/cmake/FairMQLib.cmake b/cmake/FairMQLib.cmake index c337dd8a..65b28584 100644 --- a/cmake/FairMQLib.cmake +++ b/cmake/FairMQLib.cmake @@ -144,14 +144,16 @@ macro(set_fairmq_defaults) # Configure build types set(CMAKE_CONFIGURATION_TYPES "Debug" "Release" "RelWithDebInfo" "Nightly" "Profile" "Experimental" "AdressSan" "ThreadSan") - set(CMAKE_CXX_FLAGS_DEBUG "-g -Wshadow -Wall -Wextra") + set(_warnings "-Wshadow -Wall -Wextra -Wpedantic") + set(CMAKE_CXX_FLAGS_DEBUG "-g ${_warnings}") set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG") - set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g -Wshadow -Wall -Wextra -DNDEBUG") - set(CMAKE_CXX_FLAGS_NIGHTLY "-O2 -g -Wshadow -Wall -Wextra") - set(CMAKE_CXX_FLAGS_PROFILE "-g3 -Wshadow -Wall -Wextra -fno-inline -ftest-coverage -fprofile-arcs") - set(CMAKE_CXX_FLAGS_EXPERIMENTAL "-O2 -g -Wshadow -Wall -Wextra -DNDEBUG") - set(CMAKE_CXX_FLAGS_ADRESSSAN "-O2 -g -Wshadow -Wall -Wextra -fsanitize=address -fno-omit-frame-pointer") - set(CMAKE_CXX_FLAGS_THREADSAN "-O2 -g -Wshadow -Wall -Wextra -fsanitize=thread") + set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g ${_warnings} -DNDEBUG") + set(CMAKE_CXX_FLAGS_NIGHTLY "-O2 -g ${_warnings}") + set(CMAKE_CXX_FLAGS_PROFILE "-g3 ${_warnings} -fno-inline -ftest-coverage -fprofile-arcs") + set(CMAKE_CXX_FLAGS_EXPERIMENTAL "-O2 -g ${_warnings} -DNDEBUG") + set(CMAKE_CXX_FLAGS_ADRESSSAN "-O2 -g ${_warnings} -fsanitize=address -fno-omit-frame-pointer") + set(CMAKE_CXX_FLAGS_THREADSAN "-O2 -g ${_warnings} -fsanitize=thread") + unset(_warnings) if(CMAKE_GENERATOR STREQUAL "Ninja" AND ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9) OR diff --git a/fairmq/MemoryResourceTools.h b/fairmq/MemoryResourceTools.h index e6e8f094..7ad7ebc9 100644 --- a/fairmq/MemoryResourceTools.h +++ b/fairmq/MemoryResourceTools.h @@ -60,7 +60,7 @@ FairMQMessagePtr getMessage(ContainerT &&container_, FairMQMemoryResource *targe container.data(), containerSizeBytes); return message; -}; +} } /* namespace mq */ } /* namespace fair */ diff --git a/fairmq/MemoryResources.cxx b/fairmq/MemoryResources.cxx index 3667ba12..06ff3225 100644 --- a/fairmq/MemoryResources.cxx +++ b/fairmq/MemoryResources.cxx @@ -18,5 +18,5 @@ void *fair::mq::ChannelResource::do_allocate(std::size_t bytes, std::size_t /*alignment*/) { return setMessage(factory->CreateMessage(bytes)); -}; +} diff --git a/fairmq/PluginManager.h b/fairmq/PluginManager.h index 2e409bda..085ac6b8 100644 --- a/fairmq/PluginManager.h +++ b/fairmq/PluginManager.h @@ -80,7 +80,7 @@ class PluginManager auto ForEachPluginProgOptions(std::function func) const -> void { for(const auto& pair : fPluginProgOptions) { func(pair.second); } } template - auto EmplacePluginServices(Args&&... args) -> void { fPluginServices = fair::mq::tools::make_unique(std::forward(args)...); }; + auto EmplacePluginServices(Args&&... args) -> void { fPluginServices = fair::mq::tools::make_unique(std::forward(args)...); } auto WaitForPluginsToReleaseDeviceControl() -> void { fPluginServices->WaitForReleaseDeviceControl(); } diff --git a/fairmq/ProgOptions.cxx b/fairmq/ProgOptions.cxx index c795303e..f4c47772 100644 --- a/fairmq/ProgOptions.cxx +++ b/fairmq/ProgOptions.cxx @@ -62,7 +62,7 @@ ValInfo ConvertVarValToValInfo(const po::variable_value& v) } catch (out_of_range& oor) { return {string("[unidentified_type]"), string("[unidentified_type]"), origin}; } -}; +} string ConvertVarValToString(const po::variable_value& v) { @@ -443,4 +443,4 @@ void ProgOptions::PrintOptionsRaw() const } // namespace mq -} // namespace fair \ No newline at end of file +} // namespace fair