mirror of
https://github.com/FairRootGroup/FairMQ.git
synced 2025-10-16 10:01:47 +00:00
Fix warnings produced with -Weffc++ in fairmq, base/MQ and Tutorial3.
Remaining warnings originate from boost::msm and boost::mpl. Also, warnings with missing initializer list entries for DeviceOptions are false positives, since those are PODs.
This commit is contained in:
committed by
Florian Uhlig
parent
a8854d36ac
commit
ce58ee2302
@@ -20,14 +20,19 @@
|
||||
#include "FairMQMessageNN.h"
|
||||
#include "FairMQLogger.h"
|
||||
|
||||
using namespace std;
|
||||
|
||||
FairMQMessageNN::FairMQMessageNN()
|
||||
: fSize(0)
|
||||
, fMessage(NULL)
|
||||
: fMessage(NULL)
|
||||
, fSize(0)
|
||||
, fReceiving(false)
|
||||
{
|
||||
}
|
||||
|
||||
FairMQMessageNN::FairMQMessageNN(size_t size)
|
||||
: fMessage(NULL)
|
||||
, fSize(0)
|
||||
, fReceiving(false)
|
||||
{
|
||||
fMessage = nn_allocmsg(size, 0);
|
||||
if (!fMessage)
|
||||
@@ -45,6 +50,9 @@ FairMQMessageNN::FairMQMessageNN(size_t size)
|
||||
* possible TODO: make this zero copy (will should then be as efficient as ZeroMQ).
|
||||
*/
|
||||
FairMQMessageNN::FairMQMessageNN(void* data, size_t size, fairmq_free_fn *ffn, void* hint)
|
||||
: fMessage(NULL)
|
||||
, fSize(0)
|
||||
, fReceiving(false)
|
||||
{
|
||||
fMessage = nn_allocmsg(size, 0);
|
||||
if (!fMessage)
|
||||
@@ -146,7 +154,7 @@ void FairMQMessageNN::Copy(FairMQMessage* msg)
|
||||
{
|
||||
LOG(ERROR) << "failed allocating message, reason: " << nn_strerror(errno);
|
||||
}
|
||||
std::memcpy(fMessage, msg->GetMessage(), size);
|
||||
memcpy(fMessage, msg->GetMessage(), size);
|
||||
fSize = size;
|
||||
}
|
||||
|
||||
|
@@ -49,6 +49,10 @@ class FairMQMessageNN : public FairMQMessage
|
||||
bool fReceiving;
|
||||
|
||||
void Clear();
|
||||
|
||||
/// Copy Constructor
|
||||
FairMQMessageNN(const FairMQMessageNN&);
|
||||
FairMQMessageNN operator=(const FairMQMessageNN&);
|
||||
};
|
||||
|
||||
#endif /* FAIRMQMESSAGENN_H_ */
|
||||
|
@@ -17,6 +17,8 @@
|
||||
#include "FairMQPollerNN.h"
|
||||
|
||||
FairMQPollerNN::FairMQPollerNN(const vector<FairMQSocket*>& inputs)
|
||||
: items()
|
||||
, fNumItems()
|
||||
{
|
||||
fNumItems = inputs.size();
|
||||
items = new nn_pollfd[fNumItems];
|
||||
|
@@ -20,7 +20,7 @@
|
||||
#include "FairMQPoller.h"
|
||||
#include "FairMQSocket.h"
|
||||
|
||||
using std::vector;
|
||||
using namespace std;
|
||||
|
||||
class FairMQPollerNN : public FairMQPoller
|
||||
{
|
||||
@@ -36,6 +36,10 @@ class FairMQPollerNN : public FairMQPoller
|
||||
private:
|
||||
nn_pollfd* items;
|
||||
int fNumItems;
|
||||
|
||||
/// Copy Constructor
|
||||
FairMQPollerNN(const FairMQPollerNN&);
|
||||
FairMQPollerNN operator=(const FairMQPollerNN&);
|
||||
};
|
||||
|
||||
#endif /* FAIRMQPOLLERNN_H_ */
|
@@ -19,7 +19,9 @@
|
||||
#include "FairMQLogger.h"
|
||||
|
||||
FairMQSocketNN::FairMQSocketNN(const string& type, int num, int numIoThreads)
|
||||
: fBytesTx(0)
|
||||
: fSocket()
|
||||
, fId()
|
||||
, fBytesTx(0)
|
||||
, fBytesRx(0)
|
||||
, fMessagesTx(0)
|
||||
, fMessagesRx(0)
|
||||
|
Reference in New Issue
Block a user