diff --git a/fairmq/FairMQChannel.cxx b/fairmq/FairMQChannel.cxx index ca05c971..8a9b9d82 100644 --- a/fairmq/FairMQChannel.cxx +++ b/fairmq/FairMQChannel.cxx @@ -129,7 +129,7 @@ FairMQChannel& FairMQChannel::operator=(const FairMQChannel& chan) return *this; } -FairMQSocket const & FairMQChannel::GetSocket() const +FairMQSocket & FairMQChannel::GetSocket() const { assert(fSocket); return *fSocket; diff --git a/fairmq/FairMQChannel.h b/fairmq/FairMQChannel.h index 7f538b79..207aff4b 100644 --- a/fairmq/FairMQChannel.h +++ b/fairmq/FairMQChannel.h @@ -51,7 +51,7 @@ class FairMQChannel /// Default destructor virtual ~FairMQChannel(); - FairMQSocket const & GetSocket() const; + FairMQSocket& GetSocket() const; auto Bind(const std::string& address) -> bool { diff --git a/fairmq/FairMQSocket.h b/fairmq/FairMQSocket.h index 2ec03a9f..166c34cf 100644 --- a/fairmq/FairMQSocket.h +++ b/fairmq/FairMQSocket.h @@ -35,9 +35,6 @@ class FairMQSocket virtual int64_t TrySend(std::vector>& msgVec) = 0; virtual int64_t TryReceive(std::vector>& msgVec) = 0; - virtual void* GetSocket() const = 0; - virtual int GetSocket(int nothing) const = 0; - virtual void Close() = 0; virtual void SetOption(const std::string& option, const void* value, size_t valueSize) = 0; diff --git a/fairmq/FairMQTransportFactory.h b/fairmq/FairMQTransportFactory.h index 40a0ee57..730f334b 100644 --- a/fairmq/FairMQTransportFactory.h +++ b/fairmq/FairMQTransportFactory.h @@ -63,8 +63,6 @@ class FairMQTransportFactory virtual FairMQPollerPtr CreatePoller(const std::vector& channels) const = 0; /// Create a poller for specific channels (all subchannels) virtual FairMQPollerPtr CreatePoller(const std::unordered_map>& channelsMap, const std::vector& channelList) const = 0; - /// Create a poller for two sockets - virtual FairMQPollerPtr CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const = 0; virtual FairMQUnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback = nullptr) const = 0; diff --git a/fairmq/nanomsg/FairMQPollerNN.cxx b/fairmq/nanomsg/FairMQPollerNN.cxx index 5fa3f10f..f40112ca 100644 --- a/fairmq/nanomsg/FairMQPollerNN.cxx +++ b/fairmq/nanomsg/FairMQPollerNN.cxx @@ -19,6 +19,7 @@ #include #include "FairMQPollerNN.h" +#include "FairMQSocketNN.h" #include "FairMQLogger.h" using namespace std; @@ -33,11 +34,11 @@ FairMQPollerNN::FairMQPollerNN(const vector& channels) for (int i = 0; i < fNumItems; ++i) { - fItems[i].fd = channels.at(i).GetSocket().GetSocket(1); + fItems[i].fd = static_cast(&(channels.at(i).GetSocket()))->GetSocket(); int type = 0; size_t sz = sizeof(type); - nn_getsockopt(channels.at(i).GetSocket().GetSocket(1), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); + nn_getsockopt(static_cast(&(channels.at(i).GetSocket()))->GetSocket(), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); SetItemEvents(fItems[i], type); } @@ -53,11 +54,11 @@ FairMQPollerNN::FairMQPollerNN(const vector& channels) for (int i = 0; i < fNumItems; ++i) { - fItems[i].fd = channels.at(i)->GetSocket().GetSocket(1); + fItems[i].fd = static_cast(&(channels.at(i)->GetSocket()))->GetSocket(); int type = 0; size_t sz = sizeof(type); - nn_getsockopt(channels.at(i)->GetSocket().GetSocket(1), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); + nn_getsockopt(static_cast(&(channels.at(i)->GetSocket()))->GetSocket(), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); SetItemEvents(fItems[i], type); } @@ -87,11 +88,11 @@ FairMQPollerNN::FairMQPollerNN(const unordered_map for (unsigned int i = 0; i < channelsMap.at(channel).size(); ++i) { index = fOffsetMap[channel] + i; - fItems[index].fd = channelsMap.at(channel).at(i).GetSocket().GetSocket(1); + fItems[index].fd = static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(); int type = 0; size_t sz = sizeof(type); - nn_getsockopt(channelsMap.at(channel).at(i).GetSocket().GetSocket(1), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); + nn_getsockopt(static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); SetItemEvents(fItems[index], type); } @@ -105,27 +106,6 @@ FairMQPollerNN::FairMQPollerNN(const unordered_map } } -FairMQPollerNN::FairMQPollerNN(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) - : fItems() - , fNumItems(2) - , fOffsetMap() -{ - fItems = new nn_pollfd[fNumItems]; - - fItems[0].fd = cmdSocket.GetSocket(1); - fItems[0].events = NN_POLLIN; - fItems[0].revents = 0; - - fItems[1].fd = dataSocket.GetSocket(1); - fItems[1].revents = 0; - - int type = 0; - size_t sz = sizeof(type); - nn_getsockopt(dataSocket.GetSocket(1), NN_SOL_SOCKET, NN_PROTOCOL, &type, &sz); - - SetItemEvents(fItems[1], type); -} - void FairMQPollerNN::SetItemEvents(nn_pollfd& item, const int type) { if (type == NN_REQ || type == NN_REP || type == NN_PAIR) diff --git a/fairmq/nanomsg/FairMQPollerNN.h b/fairmq/nanomsg/FairMQPollerNN.h index d8d0d895..3d1f4161 100644 --- a/fairmq/nanomsg/FairMQPollerNN.h +++ b/fairmq/nanomsg/FairMQPollerNN.h @@ -50,8 +50,6 @@ class FairMQPollerNN final : public FairMQPoller ~FairMQPollerNN() override; private: - FairMQPollerNN(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket); - nn_pollfd* fItems; int fNumItems; diff --git a/fairmq/nanomsg/FairMQSocketNN.cxx b/fairmq/nanomsg/FairMQSocketNN.cxx index 3f74eef6..357b9946 100644 --- a/fairmq/nanomsg/FairMQSocketNN.cxx +++ b/fairmq/nanomsg/FairMQSocketNN.cxx @@ -416,12 +416,7 @@ void FairMQSocketNN::Resume() fInterrupted = false; } -void* FairMQSocketNN::GetSocket() const -{ - return nullptr; // dummy method to comply with the interface. functionality not possible in zeromq. -} - -int FairMQSocketNN::GetSocket(int /*nothing*/) const +int FairMQSocketNN::GetSocket() const { return fSocket; } @@ -445,8 +440,7 @@ void FairMQSocketNN::SetOption(const string& option, const void* value, size_t v if (option == "linger") { - int val = *(static_cast(const_cast(value))); - fLinger = val; + fLinger = *static_cast(const_cast(value)); return; } @@ -459,6 +453,19 @@ void FairMQSocketNN::SetOption(const string& option, const void* value, size_t v void FairMQSocketNN::GetOption(const string& option, void* value, size_t* valueSize) { + if (option == "linger") + { + *static_cast(value) = fLinger; + return; + } + + if (option == "snd-hwm" || option == "rcv-hwm") + { + *static_cast(value) = -1; + return; + } + + int rc = nn_getsockopt(fSocket, NN_SOL_SOCKET, GetConstant(option), value, valueSize); if (rc < 0) { diff --git a/fairmq/nanomsg/FairMQSocketNN.h b/fairmq/nanomsg/FairMQSocketNN.h index 528db306..c42fbfc8 100644 --- a/fairmq/nanomsg/FairMQSocketNN.h +++ b/fairmq/nanomsg/FairMQSocketNN.h @@ -37,8 +37,7 @@ class FairMQSocketNN final : public FairMQSocket int64_t TrySend(std::vector>& msgVec) override; int64_t TryReceive(std::vector>& msgVec) override; - void* GetSocket() const override; - int GetSocket(int nothing) const override; + int GetSocket() const; void Close() override; diff --git a/fairmq/nanomsg/FairMQTransportFactoryNN.cxx b/fairmq/nanomsg/FairMQTransportFactoryNN.cxx index 7b488aaf..0d85a71c 100644 --- a/fairmq/nanomsg/FairMQTransportFactoryNN.cxx +++ b/fairmq/nanomsg/FairMQTransportFactoryNN.cxx @@ -65,11 +65,6 @@ FairMQPollerPtr FairMQTransportFactoryNN::CreatePoller(const unordered_map(new FairMQPollerNN(channelsMap, channelList)); } -FairMQPollerPtr FairMQTransportFactoryNN::CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const -{ - return unique_ptr(new FairMQPollerNN(cmdSocket, dataSocket)); -} - FairMQUnmanagedRegionPtr FairMQTransportFactoryNN::CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const { return unique_ptr(new FairMQUnmanagedRegionNN(size, callback)); diff --git a/fairmq/nanomsg/FairMQTransportFactoryNN.h b/fairmq/nanomsg/FairMQTransportFactoryNN.h index 850018dd..9fdffa37 100644 --- a/fairmq/nanomsg/FairMQTransportFactoryNN.h +++ b/fairmq/nanomsg/FairMQTransportFactoryNN.h @@ -35,7 +35,6 @@ class FairMQTransportFactoryNN final : public FairMQTransportFactory FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::unordered_map>& channelsMap, const std::vector& channelList) const override; - FairMQPollerPtr CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const override; FairMQUnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const override; diff --git a/fairmq/ofi/Poller.cxx b/fairmq/ofi/Poller.cxx index 52be52bf..81cc670a 100644 --- a/fairmq/ofi/Poller.cxx +++ b/fairmq/ofi/Poller.cxx @@ -7,6 +7,7 @@ ********************************************************************************/ #include +#include #include #include @@ -27,13 +28,13 @@ Poller::Poller(const vector& channels) fItems = new zmq_pollitem_t[fNumItems]; for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i).GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i).GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -45,13 +46,13 @@ Poller::Poller(const vector& channels) fItems = new zmq_pollitem_t[fNumItems]; for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i)->GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i)->GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i)->GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i)->GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -75,13 +76,13 @@ Poller::Poller(const unordered_map>& channelsMap, for (unsigned int i = 0; i < channelsMap.at(channel).size(); ++i) { index = fOffsetMap[channel] + i; - fItems[index].socket = channelsMap.at(channel).at(i).GetSocket().GetSocket(); + fItems[index].socket = static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(); fItems[index].fd = 0; fItems[index].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channelsMap.at(channel).at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[index], type); } @@ -93,27 +94,6 @@ Poller::Poller(const unordered_map>& channelsMap, } } -Poller::Poller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) - : fNumItems{2} -{ - fItems = new zmq_pollitem_t[fNumItems]; - - fItems[0].socket = cmdSocket.GetSocket(); - fItems[0].fd = 0; - fItems[0].events = ZMQ_POLLIN; - fItems[0].revents = 0; - - fItems[1].socket = dataSocket.GetSocket(); - fItems[1].fd = 0; - fItems[1].revents = 0; - - int type = 0; - size_t size = sizeof(type); - zmq_getsockopt(dataSocket.GetSocket(), ZMQ_TYPE, &type, &size); - - SetItemEvents(fItems[1], type); -} - auto Poller::SetItemEvents(zmq_pollitem_t& item, const int type) -> void { if (type == ZMQ_PAIR) { diff --git a/fairmq/ofi/Poller.h b/fairmq/ofi/Poller.h index 9059483b..f59d4385 100644 --- a/fairmq/ofi/Poller.h +++ b/fairmq/ofi/Poller.h @@ -57,8 +57,6 @@ class Poller final : public FairMQPoller ~Poller() override; private: - Poller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket); - zmq_pollitem_t* fItems; int fNumItems; diff --git a/fairmq/ofi/Socket.h b/fairmq/ofi/Socket.h index d82bad1c..f380cbdc 100644 --- a/fairmq/ofi/Socket.h +++ b/fairmq/ofi/Socket.h @@ -54,8 +54,7 @@ class Socket final : public fair::mq::Socket auto TrySend(std::vector& msgVec) -> int64_t override; auto TryReceive(std::vector& msgVec) -> int64_t override; - auto GetSocket() const -> void* override { return fControlSocket; } - auto GetSocket(int nothing) const -> int override { return -1; } + auto GetSocket() const -> void* { return fControlSocket; } void SetLinger(const int value) override; int GetLinger() const override; diff --git a/fairmq/ofi/TransportFactory.cxx b/fairmq/ofi/TransportFactory.cxx index 41229c93..0bfd2fd6 100644 --- a/fairmq/ofi/TransportFactory.cxx +++ b/fairmq/ofi/TransportFactory.cxx @@ -76,11 +76,6 @@ auto TransportFactory::CreatePoller(const unordered_map PollerPtr -{ - return PollerPtr{new Poller(cmdSocket, dataSocket)}; -} - auto TransportFactory::CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const -> UnmanagedRegionPtr { throw runtime_error{"Not yet implemented UMR."}; diff --git a/fairmq/ofi/TransportFactory.h b/fairmq/ofi/TransportFactory.h index df6a8d6a..73475d39 100644 --- a/fairmq/ofi/TransportFactory.h +++ b/fairmq/ofi/TransportFactory.h @@ -43,7 +43,6 @@ class TransportFactory final : public FairMQTransportFactory auto CreatePoller(const std::vector& channels) const -> PollerPtr override; auto CreatePoller(const std::vector& channels) const -> PollerPtr override; auto CreatePoller(const std::unordered_map>& channelsMap, const std::vector& channelList) const -> PollerPtr override; - auto CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const -> PollerPtr override; auto CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback = nullptr) const -> UnmanagedRegionPtr override; diff --git a/fairmq/shmem/FairMQPollerSHM.cxx b/fairmq/shmem/FairMQPollerSHM.cxx index c7e852dc..5beda2e2 100644 --- a/fairmq/shmem/FairMQPollerSHM.cxx +++ b/fairmq/shmem/FairMQPollerSHM.cxx @@ -13,6 +13,7 @@ */ #include "FairMQPollerSHM.h" +#include "FairMQSocketSHM.h" #include "FairMQLogger.h" #include @@ -29,13 +30,13 @@ FairMQPollerSHM::FairMQPollerSHM(const vector& channels) for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i).GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i).GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -51,13 +52,13 @@ FairMQPollerSHM::FairMQPollerSHM(const vector& channels) for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i)->GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i)->GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i)->GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i)->GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -88,13 +89,13 @@ FairMQPollerSHM::FairMQPollerSHM(const unordered_map(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(); fItems[index].fd = 0; fItems[index].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channelsMap.at(channel).at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[index], type); } @@ -108,29 +109,6 @@ FairMQPollerSHM::FairMQPollerSHM(const unordered_map>& msgVec) override; int64_t TryReceive(std::vector>& msgVec) override; - void* GetSocket() const override; - int GetSocket(int nothing) const override; + void* GetSocket() const; void Close() override; diff --git a/fairmq/shmem/FairMQTransportFactorySHM.cxx b/fairmq/shmem/FairMQTransportFactorySHM.cxx index 72bf3b13..97bfc83d 100644 --- a/fairmq/shmem/FairMQTransportFactorySHM.cxx +++ b/fairmq/shmem/FairMQTransportFactorySHM.cxx @@ -254,11 +254,6 @@ FairMQPollerPtr FairMQTransportFactorySHM::CreatePoller(const unordered_map(new FairMQPollerSHM(channelsMap, channelList)); } -FairMQPollerPtr FairMQTransportFactorySHM::CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const -{ - return unique_ptr(new FairMQPollerSHM(cmdSocket, dataSocket)); -} - FairMQUnmanagedRegionPtr FairMQTransportFactorySHM::CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const { return unique_ptr(new FairMQUnmanagedRegionSHM(*fManager, size, callback)); diff --git a/fairmq/shmem/FairMQTransportFactorySHM.h b/fairmq/shmem/FairMQTransportFactorySHM.h index dc4e9500..909be96f 100644 --- a/fairmq/shmem/FairMQTransportFactorySHM.h +++ b/fairmq/shmem/FairMQTransportFactorySHM.h @@ -43,7 +43,6 @@ class FairMQTransportFactorySHM final : public FairMQTransportFactory FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::unordered_map>& channelsMap, const std::vector& channelList) const override; - FairMQPollerPtr CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const override; FairMQUnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback = nullptr) const override; diff --git a/fairmq/zeromq/FairMQPollerZMQ.cxx b/fairmq/zeromq/FairMQPollerZMQ.cxx index 235ec35f..a593eacf 100644 --- a/fairmq/zeromq/FairMQPollerZMQ.cxx +++ b/fairmq/zeromq/FairMQPollerZMQ.cxx @@ -15,6 +15,7 @@ #include #include "FairMQPollerZMQ.h" +#include "FairMQSocketZMQ.h" #include "FairMQLogger.h" using namespace std; @@ -29,13 +30,13 @@ FairMQPollerZMQ::FairMQPollerZMQ(const vector& channels) for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i).GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i).GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -52,13 +53,13 @@ FairMQPollerZMQ::FairMQPollerZMQ(const std::vector& channe for (int i = 0; i < fNumItems; ++i) { - fItems[i].socket = channels.at(i)->GetSocket().GetSocket(); + fItems[i].socket = static_cast(&(channels.at(i)->GetSocket()))->GetSocket(); fItems[i].fd = 0; fItems[i].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channels.at(i)->GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channels.at(i)->GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[i], type); } @@ -89,13 +90,13 @@ FairMQPollerZMQ::FairMQPollerZMQ(const unordered_map(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(); fItems[index].fd = 0; fItems[index].revents = 0; int type = 0; size_t size = sizeof(type); - zmq_getsockopt(channelsMap.at(channel).at(i).GetSocket().GetSocket(), ZMQ_TYPE, &type, &size); + zmq_getsockopt(static_cast(&(channelsMap.at(channel).at(i).GetSocket()))->GetSocket(), ZMQ_TYPE, &type, &size); SetItemEvents(fItems[index], type); } @@ -109,29 +110,6 @@ FairMQPollerZMQ::FairMQPollerZMQ(const unordered_map>& msgVec) override; int64_t TryReceive(std::vector>& msgVec) override; - void* GetSocket() const override; - int GetSocket(int nothing) const override; + void* GetSocket() const; void Close() override; diff --git a/fairmq/zeromq/FairMQTransportFactoryZMQ.cxx b/fairmq/zeromq/FairMQTransportFactoryZMQ.cxx index c291adb6..93cdb093 100644 --- a/fairmq/zeromq/FairMQTransportFactoryZMQ.cxx +++ b/fairmq/zeromq/FairMQTransportFactoryZMQ.cxx @@ -90,11 +90,6 @@ FairMQPollerPtr FairMQTransportFactoryZMQ::CreatePoller(const unordered_map(new FairMQPollerZMQ(channelsMap, channelList)); } -FairMQPollerPtr FairMQTransportFactoryZMQ::CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const -{ - return unique_ptr(new FairMQPollerZMQ(cmdSocket, dataSocket)); -} - FairMQUnmanagedRegionPtr FairMQTransportFactoryZMQ::CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const { return unique_ptr(new FairMQUnmanagedRegionZMQ(size, callback)); diff --git a/fairmq/zeromq/FairMQTransportFactoryZMQ.h b/fairmq/zeromq/FairMQTransportFactoryZMQ.h index a8d94cff..b2917b81 100644 --- a/fairmq/zeromq/FairMQTransportFactoryZMQ.h +++ b/fairmq/zeromq/FairMQTransportFactoryZMQ.h @@ -44,7 +44,6 @@ class FairMQTransportFactoryZMQ final : public FairMQTransportFactory FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::vector& channels) const override; FairMQPollerPtr CreatePoller(const std::unordered_map>& channelsMap, const std::vector& channelList) const override; - FairMQPollerPtr CreatePoller(const FairMQSocket& cmdSocket, const FairMQSocket& dataSocket) const override; FairMQUnmanagedRegionPtr CreateUnmanagedRegion(const size_t size, FairMQRegionCallback callback) const override;