From 63e7850ad3331d6289fcb5682f5b34be9b5315b8 Mon Sep 17 00:00:00 2001
From: Alexey Rybalchenko <alexryba@gmail.com>
Date: Thu, 9 Jul 2020 14:01:44 +0200
Subject: [PATCH] Throw if removing non-existing sink or adding existing

---
 logger/Logger.cxx | 2 ++
 logger/Logger.h   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/logger/Logger.cxx b/logger/Logger.cxx
index 27ec2e1..fb11506 100644
--- a/logger/Logger.cxx
+++ b/logger/Logger.cxx
@@ -577,6 +577,7 @@ void Logger::AddCustomSink(const string& key, Severity severity, function<void(c
         UpdateMinSeverity();
     } else {
         cout << "Logger::AddCustomSink: sink '" << key << "' already exists, will not add again. Remove first with Logger::RemoveCustomSink(const string& key)" << endl;
+        throw runtime_error("Adding a sink with a key that already exists. Remove first.");
     }
 }
 
@@ -597,6 +598,7 @@ void Logger::RemoveCustomSink(const string& key)
         UpdateMinSeverity();
     } else {
         cout << "Logger::RemoveCustomSink: sink '" << key << "' doesn't exists, will not remove." << endl;
+        throw runtime_error("Trying to remove a sink with a key that does not exist.");
     }
 }
 
diff --git a/logger/Logger.h b/logger/Logger.h
index fba5fc9..b5b09af 100644
--- a/logger/Logger.h
+++ b/logger/Logger.h
@@ -39,6 +39,7 @@
 #include <mutex>
 #include <ostream>
 #include <sstream>
+#include <stdexcept>
 #include <string>
 #include <time.h> // time_t
 #include <type_traits> // is_same