Mirror/FairLogger
1
0
Fork 0
mirror of https://github.com/FairRootGroup/FairLogger.git synced 2025-10-13 16:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

guard localtime with a mutex to avoid race

Browse Source
This commit is contained in:
Alexey Rybalchenko 2018-07-30 14:24:47 +02:00 committed by Dennis Klein
parent 63820e5f2c
commit 1f600fa981
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
logger/Logger.cxx
View File

@ -575,9 +575,12 @@ void Logger::RemoveCustomSink(const string& key)
Logger& Logger::Log() Logger& Logger::Log()
{ {
char tsstr[32]; char tsstr[32];
if (!strftime(tsstr, sizeof(tsstr), "%H:%M:%S", localtime(&(fMetaData.timestamp))))
{ {
tsstr[0] = 'u'; lock_guard<mutex> lock(fMtx); // localtime is not threadsafe, guard it
if (!strftime(tsstr, sizeof(tsstr), "%H:%M:%S", localtime(&(fMetaData.timestamp))))
{
tsstr[0] = 'u';
}
} }
if ((!fColored && LoggingToConsole()) || LoggingToFile()) if ((!fColored && LoggingToConsole()) || LoggingToFile())